This review focuses on the role personality traits and cognitive abilities play for criteria of occupational success, i.e. job performance and career success. First, an overview of the international state of the art, meta-analytical results, and current debates are presented, then current German findings are summarized. This summary of German research illustrates that German personality and intelligence tests have not yet been sufficiently validated with respect to job-relevant criteria. This may be one reason why personality and intelligence tests are relatively rarely used for personnel selection in Germany, despite the international evidence for their validity. Implications are presented which might contribute to reconciling research and practice in Germany.